This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Fix Bug in Dragable example #2465
Closed
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petebacondarwin
added a commit
that referenced
this pull request
Apr 22, 2013
In the example with draggable, the mouseDown handler needs to start with an event.preventDefault(). Otherwise the following bug occurs: 1) Select the text of the draggable span by clicking outside the span and dragging the mouse to the left or right through the span. Release the mouse button. 2) Now click on the span's inner text, and start to Drag it. The browser's default functionality that drags highlighted text so that it can be pasted into something else (say a document in a text editor) is invoked. 3) Release the mouse button. Now suddenly, you'll be dragging the span. But you won't be able to place it down on the page. It'll just follow the mouse around until the page is refreshed. Closes: #2465
petebacondarwin
added a commit
that referenced
this pull request
Apr 22, 2013
In the example with draggable, the mouseDown handler needs to start with an event.preventDefault(). Otherwise the following bug occurs: 1) Select the text of the draggable span by clicking outside the span and dragging the mouse to the left or right through the span. Release the mouse button. 2) Now click on the span's inner text, and start to Drag it. The browser's default functionality that drags highlighted text so that it can be pasted into something else (say a document in a text editor) is invoked. 3) Release the mouse button. Now suddenly, you'll be dragging the span. But you won't be able to place it down on the page. It'll just follow the mouse around until the page is refreshed. Closes: #2465
|
Actually this needs to go in the mousedown event. Landed as de296f1. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested in Tested in latest Chrome 26.0.1410.65 for OS X
In the example with draggable, the mouseDown handler needs to start with an
event.preventDefault(). Otherwise the following bug occurs:The added line fixes this.