Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix(ngRepeat): correctly iterate over array-like objects #2554

Closed

Conversation

gonzaloruizdevilla
Copy link
Contributor

Check if the object is array-like to iterate over it like it's done with arrays.

Closes #2546

@petebacondarwin
Copy link
Member

  • Contributor signed CLA now or in the past (if you just signed, leave a comment here with your real name)
  • PR doesn't introduce new api
  • PR doesn't contain a breaking change
  • PR contains unit tests
  • PR contains e2e tests (if suitable)
  • PR contains documentation update (if suitable)
  • PR passes all tests on Travis (sanity)
  • PR passes all tests on ci.angularjs.org (cross-browser compatibility)
  • PR is rebased against recent master
  • PR is squashed into one commit per logical change
  • PR's commit messages are descriptive and allows us to autogenerate release notes (required commit message format)
  • All changes requested in review have been implemented

@petebacondarwin
Copy link
Member

This is failing on IE8: http://ci.angularjs.org/job/angular.js-pete/122/console

Gonzalo Ruiz de Villa added 2 commits May 2, 2013 13:03
@gonzaloruizdevilla
Copy link
Contributor Author

$watchCollection needed to use isArrayLike instead of isArray to prevent this error in IE8. I pushed the change with its test in another commit.

I've already signed the CLA as Gonzalo Ruiz de Villa

@petebacondarwin
Copy link
Member

Landed at 1d8e11d

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ng-repeat="file in filelist" does not work properly
2 participants