Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Switched package.json Dependencies to be devDependencies #2699

Closed
wants to merge 1 commit into from

Conversation

dankohn
Copy link
Contributor

@dankohn dankohn commented May 18, 2013

None of the dependencies are necessary for using the library, so they should all be devDependencies.

This allows the Angular library to be fetched with npm (e.g., npm install --save https://github.com/angular/angular.js.git#v1.0.x).

You can also apply this patch to HEAD, and just fix the version number, or I can submit a new pull request.

@petebacondarwin
Copy link
Contributor

This seems reasonable, since npm install will install devDependencies by default anyway so it is not a breaking change. @IgorMinar - any thoughts on this?

@dankohn
Copy link
Contributor Author

dankohn commented May 20, 2013

FYI, my ultimate goal here is to convince the Angular team to publish angular.js as an npm package, which I will then be able to include without grabbing the devDependencies. I'm using browserify to package up client side libraries I fetch with npm (though in production, I will reference a copy on the CDN). This will also let me see new Angular releases using npm outdated. Also, note that jQuery is taking over the npm management of their library: HorseAJ86/node-jquery#56

@IgorMinar
Copy link
Contributor

landed as eb21eb5

I also added d458d73 to get you closer to your goal.

@IgorMinar IgorMinar closed this May 21, 2013
@darvin
Copy link

darvin commented May 30, 2013

@dankohn , did you ever finished your work? I'm trying to user angular/mocha/browserify in one project and I would be happy to require angular as require("angular") instead of current ugly stuff

@dankohn
Copy link
Contributor Author

dankohn commented Jun 5, 2013

@IgorMinar thanks for pull and the additional commit. I created #2877 to see about publishing Angular as an npm module.

@darvin it now works to npm install git://github.com/angular/angular.js.git#v1.0.7 and then require("AngularJS"). Curently npm install git://github.com/angular/angular.js.git#v1.0.x pulls down 1.0.8-snapshot, which is not ideal. Hopefully the Angular developers will agree to publish the latest stable release to npm.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants