-
Notifications
You must be signed in to change notification settings - Fork 27.4k
Conversation
PR Checklist (Minor Feature)
|
@andi1984 Thnx for this pull request. It will require a bit more work before it can be considered for merging - I've included a checklist for you. You can take a look at the similar PR that adds support for events to see how the documentation should be added: Also your commit message should be updated to follow the guidelines and mention that it closes |
+1 :) |
+1 |
@pkozlowski-opensource Thanks for the patience explaining how to commit my changes to form a proper pull request. I've added the missing documentation (sorry for that, I should have included that directly) and tests in my last commit. I also signed the Contributor License Agreement (CLA) a few mins ago. |
@andi1984 please squash both commits together and use the commit message of the 2nd commit. |
@matsko Done. |
@andi1984 thnx for doing all the changes. One more thing - your last commit seems to be based on the 1-month old master and doesn't merge cleanly any more. Would you mind rebasing it on the latest master and do a forced push? git rebase master |
@pkozlowski-opensource Sorry for the trouble. Somehow I didn't get managed to rebase my old, already pushed commit (based on old master), with the newly merged master, I simply started from scratch due to the simplicity of my PR. In future I will start branches for each single PR, keep them in sync with the master and commit them with one single commit to the master, to start a pull request. That's the way it should be done, I know. Based on git, I've to learn a lot because I'm not a git pro user ;-) Hope my last commit fits your needs to merge it into angularjs master. |
@pkozlowski-opensource Can you restart travis build because I couldn't. Somehow timed out... |
You can only restart a build by pushing new commits. Try: On 16 July 2013 23:20, Andreas Sander notifications@github.com wrote:
|
Added directives for focus and blur events. Closes #1277
@petebacondarwin Thanks! I've gone through the commands right now. Hope it works as expected now. |
Landed as 2bb27d4. Thank you! And hey, thnx for going through all this changes to get the commit right. Much appreciated. |
I've added
ng-focus
andng-blur
as two further default event directives which should be available for users inside AngularJS.