Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(docs-bootstrap): Removed injector from bootstrapped docs samples. #3458

Closed
wants to merge 1 commit into from

Conversation

jeffbcross
Copy link
Contributor

This is necessary to make e2e tests pass for implementing #3411. At present, the docs are violating the rule being enforced by double-bootstrap prevention.

There's still some work to be done before merging:

  • Write unit tests
  • Implement feature
  • Pass all new and existing tests on CI

@mary-poppins
Copy link

Thanks for the PR!

  • Contributor signed CLA now or in the past
    • If you just signed, leave a comment here with your real name
  • PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@petebacondarwin
Copy link
Contributor

Perhaps we should add a little jqLite unit test in for this?

@jeffbcross
Copy link
Contributor Author

Yes, Misko and I put this together in a hurry and I added some todos in my PR message to come back to this when time frees up.

This is necessary to make e2e tests pass for implementing angular#3411. At present, the docs are violating the rule being enforced by double-bootstrap prevention.
@jeffbcross
Copy link
Contributor Author

@jeffbcross
Copy link
Contributor Author

Merged

@jeffbcross jeffbcross closed this Aug 9, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants