Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix($scope): $evalAsync executes on the right scope #3549

Closed
wants to merge 1 commit into from

Conversation

lgalfaso
Copy link
Contributor

Executes $evalAsync on the scope that the call was made.

Closes: #3548

Executes $evalAsync at the scope that the call was made

Closes: angular#3548
@mary-poppins
Copy link

Thanks for the PR!

  • Contributor signed CLA now or in the past
    • If you just signed, leave a comment here with your real name
  • PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@janv
Copy link

janv commented Aug 14, 2013

@mary-poppins @lgalfaso How's the progress on this?
Seeing that 1.2.0RC1 got released last night, this seems like a no-brainer to include there.
Still waiting for the CLA?

@lgalfaso
Copy link
Contributor Author

@janv I think @mary-poppins is a bot
I did signed the CLA and the commit has the right format (well, at least it valid according to validate-commit-msg.js). We will have to wait until one core team member reviews the PR

@btford
Copy link
Contributor

btford commented Oct 2, 2013

This is a valid issue. Thanks for the PR @lgalfaso!

@ghost ghost assigned btford Oct 2, 2013
@btford
Copy link
Contributor

btford commented Oct 2, 2013

Landed as 10cc1a4.

@btford btford closed this Oct 2, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$evalAsync does not follow $eval semantics, runs on $rootScope, not current Scope
4 participants