feat($http) XHR progress events #3606
Conversation
|
Thanks for the PR!
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
|
@caiotoon please make sure
|
| /** | ||
| * Progress callback for $httpBackend | ||
| */ | ||
| function progress(event){ |
There was a problem hiding this comment.
space before { - please fix this everywhere...
ghost
assigned 
|
I can just close this request and reopen a new one that's properly rebased and has the needed updates. Really just wanted to get some input on how to test it. I can add some calls to |
|
No need to open a new issue; just amend the commit and force push to your branch. |
|
Sounds good, I'll try to take care of the changes ASAP. |
|
@mikeycgto use MockXhr (from angular-mocks.js) and test that the notify handler is called when using |
|
@vojtajina I didn't got what should I rebase, sorry. Wasn't the promise notification already merged? What should I rebase? |
|
Was able to rebase this commit and fix up the things that needed fixing. Also filled out and submitted the CLA. Sorry for the epic delay! |
Add to $http and $httpBackend to open up progress events. Update specs and mocks to handle the new argument and to test for the $http promise notify method. Closes #1934
|
I would love to see this be merged - any updates? |
|
chances of this getting merged before 1.3? |
|
I would like to see the feature available soon. Thanks. |
petebacondarwin
force-pushed
the
master
branch
from
02dc2aa to
fd2d6c0
Compare
jeffbcross
force-pushed
the
master
branch
2 times, most recently
from
cad9560 to
f294244
Compare
jeffbcross
force-pushed
the
master
branch
3 times, most recently
from
8292c21 to
7b9fddf
Compare
petebacondarwin
force-pushed
the
master
branch
from
4dd5a20 to
998c61c
Compare
|
@mikeycgto / All interested in this PR: based on the discussion in #1934 (staring from here) it seems like the general trend is to remove notifications (at least in the current form) from promises. As such we don't want to solve the problem of progress notifications using promise APIs. I'm going to close this PR (and similar ones: #3606, #5874, #9258) and focus on the callback-based solution instead (similar to the one proposed in #7995). We still do appreciate your effort on this issue which seems to be important to many people - so if you care about progress notifications being available in AngularJS please let's have discussion in #7995. |
Should likely add a few more specs for this. Any suggestions? May need to add to
MockXHRa bit.