Fix hashchange event on IE7

[vojtajina]

Stupid IE7 returns true for ('onhashchange' in window), but does not support hashchange event.

Fix hashchange event on IE7

Stupid IE7 returns true for ('onhashchange' in window), but does not support hashchange event.

Instead of using sniffing tricks like this:

window.setAttribute('onhashchange', 'return;');
typeof window.onhashchange == 'function';

I decided to check msie version. That's why had to remove two unit tests:

• should use $browser poller to detect url changes when onhashchange event is unsupported
• should use onhashchange events to detect url changes when supported by browser

I hope that's all right - we don't care whether event or poller is used. We just check whether the $browser.onHashChange event works, running the tests in all browsers.

[esprehn]

Pretty sure this is not IE7, but IE8 in compatibility mode that lies about the property.

I'd leave the unit tests. I think it's bad to have to run the tests in every browser to execute the two code paths properly. You should be able to have Chrome only attached to jstd when developing and not worry about accidentally breaking poller. Of course Igor's opinion on this is probably more important. :)

[vojtajina]

Hey, you are probably right - I don't have real IE7.
I use IE8 and both IE8 compatibility mode and IE7 mode lie about the property.

I would leave these tests, but now, the behavior relies on msie property, so I would have to mutate this global property to get the test passed on IE7.

Will discuss that with Igor, thanks for the comment...

[IgorMinar]

as discussed today - please change this to use compatibility mode detection just like modernizr

as far as elliott's comment about two execution paths goes - this is browser.js, it is messy, ugly and dirty just like the DOM api, so I think it's ok that we have the branch here.

[IgorMinar]

angular.js: master commits aa64d37...dad2603 - http://bit.ly/ldzsiA