Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Conversation

vojtajina
Copy link
Contributor

I did small change in your code:

element.attr('href') === null
// to
!element.attr('href')

This converts links <a href ng:click=""> into underlined link in IE7 as well.
Hope it should be fine now...

ng:href was producing unclickable links, as the event propagation was stopped by 'a' widget

All links in regression/issue-352.html were tested in:

  • Chrome 11
  • Opera 11
  • Firefox 4
  • IE7, IE8

Closes #352

ng:href was producing unclickable links, as the event propagation was stopped by 'a' widget

All links in regression/issue-352.html were tested in:

* Chrome 11
* Opera 11
* Firefox 4
* IE7, IE8

Closes angular#352
@IgorMinar
Copy link
Contributor

added more tests and committed as:

angular.js: master Vojta Jina * 4b0f2df (2 files in 1 dirs): Fix IE bug - ng:href ... - http://bit.ly/ijKpod

@IgorMinar IgorMinar closed this Jun 2, 2011
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ng:href produces unclickable links on IE7

2 participants