Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

feat(currencyFilter): add numbers after dot count parameter #3642

Closed
wants to merge 1 commit into from

Conversation

allaud
Copy link

@allaud allaud commented Aug 18, 2013

So we can format currency numbers like this:
expect(currency(1234.5678, "USD$")).toEqual('USD$1,234.57')
expect(currency(1234.5678, "rub", 3)).toEqual('rub1,234.568')
expect(currency(1234.5678, "rub", 0)).toEqual('rub1,234')
The last case is usual for Rubles for example.

There is also a target to remove hardcoded values from source.

@allaud
Copy link
Author

allaud commented Sep 15, 2013

@btford how can I pick value from currencySymbols.js in angular-locale_xx.js ?

So we can format currency numbers like this:
expect(currency(1234.5678, "USD$")).toEqual('USD$1,234.57')
expect(currency(1234.5678, "rub", 3)).toEqual('rub1,234.568')
expect(currency(1234.5678, "rub", 0)).toEqual('rub1,234')
The last case is usual for Rubles for example.
@allaud
Copy link
Author

allaud commented Oct 28, 2013

@btford @IgorMinar got it. Just updated with defaults from currencySymbols.

@IgorMinar
Copy link
Contributor

I'm sorry, but I wasn't able to verify your CLA signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let me know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@allaud allaud added cla: no and removed cla: yes labels Feb 19, 2014
@allaud allaud added cla: no and removed cla: yes labels Mar 19, 2014
@allaud allaud added cla: no and removed cla: yes labels Mar 31, 2014
doshprompt added a commit to doshprompt/angular.js that referenced this pull request Jun 20, 2014
currencyFilter accepts number of decimals to round off to

Closes angular#3642
doshprompt added a commit to doshprompt/angular.js that referenced this pull request Jun 23, 2014
currencyFilter accepts number of decimals to round off to

Closes angular#3642
doshprompt added a commit to doshprompt/angular.js that referenced this pull request Jun 23, 2014
currencyFilter accepts number of decimals to round off to

Closes angular#3642
doshprompt added a commit to doshprompt/angular.js that referenced this pull request Jun 23, 2014
currencyFilter accepts number of decimals to round off to

Closes angular#3642
@jeffbcross jeffbcross force-pushed the master branch 2 times, most recently from cad9560 to f294244 Compare October 2, 2014 22:08
@jeffbcross jeffbcross force-pushed the master branch 2 times, most recently from abdaab7 to 30996f8 Compare October 8, 2014 19:46
@jeffbcross jeffbcross force-pushed the master branch 2 times, most recently from e8dc429 to e83fab9 Compare October 10, 2014 17:37
@IgorMinar IgorMinar closed this in 20685ff Oct 11, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants