This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Add note to make the naming convention in specs more visible when testin... #3718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -107,7 +107,7 @@ describe('filter', function() { | |||
| </pre> | |||
|
|
|||
| Note that you need to configure our test injector with the `phonecatFilters` module before any of | |||
| our filter tests execute. | |||
| our filter tests execute. Please note also the naming convention to inject the filter. | |||
There was a problem hiding this comment.
I think that it should say something like "Please note how we are using the inject helper function to inject filter into the spec."
petebacondarwin
added a commit
that referenced
this pull request
Sep 5, 2013
|
@petebacondarwin many thanks for this improvement, it will prevent a lot of headaches! |
jamesdaily
pushed a commit
to jamesdaily/angular.js
that referenced
this pull request
Sep 25, 2013
jamesdaily
pushed a commit
to jamesdaily/angular.js
that referenced
this pull request
Jan 27, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...g filters.