This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Document $q's notify behaviour #3755
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * This method *returns a new promise* which is resolved or rejected via the return value of the | ||
| * `successCallback` or `errorCallback`. | ||
| * `successCallback`, `errorCallback`, or `notifyCallback`. |
There was a problem hiding this comment.
Is it possible for a notifyCallback to resolve/reject a promise? From a quick inspection, their return values seem to be completely ignored here.
There was a problem hiding this comment.
From what I read you can't resolve or reject the promise from notifyCallback.
I'll doublecheck and add a note about that.
There was a problem hiding this comment.
I don't think a note is necessary, just reverting this line should be enough.
There was a problem hiding this comment.
Ah didn't push that commit yesterday. The same question came up in the original ticket, so in my eyes it warrants a quick note. See me latest change.
|
Squashed, corrected the commit msg and merged as c65fcc0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added basic documentation on $q's notify behaviour.
Closes #3341