This repository was archived by the owner on Apr 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27.3k
feat($interval) add a service wrapping setInterval #4047
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,90 @@ | ||
'use strict'; | ||
|
||
|
||
function $IntervalProvider() { | ||
this.$get = ['$rootScope', '$window', '$q', | ||
function($rootScope, $window, $q) { | ||
var intervals = {}; | ||
|
||
|
||
/** | ||
* @ngdoc function | ||
* @name ng.$interval | ||
* | ||
* @description | ||
* Angular's wrapper for `window.setInterval`. The `fn` function is executed every `delay` | ||
* milliseconds. | ||
* | ||
* The return value of registering an interval function is a promise. This promise will be | ||
* notified upon each tick of the interval, and will be resolved after `count` iterations, or | ||
* run indefinitely if `count` is not defined. The value of the notification will be the | ||
* number of iterations that have run. | ||
* To cancel an interval, call `$interval.cancel(promise)`. | ||
* | ||
* In tests you can use {@link ngMock.$interval#flush `$interval.flush(millis)`} to | ||
* move forward by `millis` milliseconds and trigger any functions scheduled to run in that | ||
* time. | ||
* | ||
* @param {function()} fn A function that should be called repeatedly. | ||
* @param {number} delay Number of milliseconds between each function call. | ||
* @param {number=} [count=0] Number of times to repeat. If not set, or 0, will repeat | ||
* indefinitely. | ||
* @param {boolean=} [invokeApply=true] If set to `false` skips model dirty checking, otherwise | ||
* will invoke `fn` within the {@link ng.$rootScope.Scope#$apply $apply} block. | ||
* @returns {promise} A promise which will be notified on each iteration. | ||
*/ | ||
function interval(fn, delay, count, invokeApply) { | ||
var setInterval = $window.setInterval, | ||
clearInterval = $window.clearInterval; | ||
|
||
var deferred = $q.defer(), | ||
promise = deferred.promise, | ||
count = (isDefined(count)) ? count : 0, | ||
iteration = 0, | ||
skipApply = (isDefined(invokeApply) && !invokeApply); | ||
|
||
promise.then(null, null, fn); | ||
|
||
promise.$$intervalId = setInterval(function tick() { | ||
deferred.notify(iteration++); | ||
|
||
if (count > 0 && iteration >= count) { | ||
deferred.resolve(iteration); | ||
clearInterval(promise.$$intervalId); | ||
delete intervals[promise.$$intervalId]; | ||
} | ||
|
||
if (!skipApply) $rootScope.$apply(); | ||
|
||
}, delay); | ||
|
||
intervals[promise.$$intervalId] = deferred; | ||
|
||
return promise; | ||
} | ||
|
||
|
||
/** | ||
* @ngdoc function | ||
* @name ng.$interval#cancel | ||
* @methodOf ng.$interval | ||
* | ||
* @description | ||
* Cancels a task associated with the `promise`. | ||
* | ||
* @param {number} promise Promise returned by the `$interval` function. | ||
* @returns {boolean} Returns `true` if the task was successfully canceled. | ||
*/ | ||
interval.cancel = function(promise) { | ||
if (promise && promise.$$intervalId in intervals) { | ||
intervals[promise.$$intervalId].reject('canceled'); | ||
clearInterval(promise.$$intervalId); | ||
delete intervals[promise.$$intervalId]; | ||
return true; | ||
} | ||
return false; | ||
}; | ||
|
||
return interval; | ||
}]; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we return this promise instead ?
If the user processes the returned value (the iteration number in this case), this promise returned by
$interval
won't get it:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about it a bit more and I think the current behavior is correct, because:
fn
callback should not be in the flow of the promise - if there's an exception in the callback it should still notify