This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngTranslude): detect ngTranslude usage without a translusion directive #4162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR!
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
| @@ -53,6 +53,10 @@ | |||
| */ | |||
| var ngTranscludeDirective = ngDirective({ | |||
| controller: ['$transclude', function($transclude) { | |||
| if (!$transclude) { | |||
| throw new Error('Cannot use ng-translude without a translusion directive'); | |||
|
also it should be marked as "fix" not "chore". (chores don't show up in release notes) |
| @@ -1,5 +1,7 @@ | |||
| 'use strict'; | |||
|
|
|||
| var $ngTranscludeMinErr = minErr('ngTransclude'); | |||
There was a problem hiding this comment.
since you need only one error with this namespace, the convention is to inline the minErr call
There was a problem hiding this comment.
That does not seem to be a good convention IMO but sure.
|
otherwise this looks good to me |
|
looks good to me |
ghost
assigned
|
Actually it needs a spot in the message to interpolate the starting element. It also needs an error page for the docs. I'll fix it. |
|
Landed as 5a1a6b8 ultimately. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3759