This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fixes #2235: fix docs for directive replace:false #4166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR!
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
Previous version stated `replace:false` will append template to element. Improve description to accurately state that template will _replace_ the contents of the current element. Closes #2235
|
I've signed the CLA as "Ron Waldon" (my real name). |
ghost
assigned 
|
Landed as 106ee8f. Thanks |
jamesdaily
pushed a commit
to jamesdaily/angular.js
that referenced
this pull request
Jan 27, 2014
Previous version stated `replace:false` will append template to element. Improve description to accurately state that template will _replace_ the contents of the current element. Closes angular#2235, angular#4166
jamesdaily
pushed a commit
to jamesdaily/angular.js
that referenced
this pull request
Jan 27, 2014
Previous version stated `replace:false` will append template to element. Improve description to accurately state that template will _replace_ the contents of the current element. Closes angular#2235, angular#4166
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #2235, the documentation for how directives behave regarding
replace: falsefalls short of explaining what will happen to the contents of the current element.This pull request has a minor change to the documentation to make explicit what happens in this case.