Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(ngShowHide): stop ngShow and ngHide applying animations incorrectly #4479

Closed
wants to merge 1 commit into from
Closed

Conversation

grantyb
Copy link

@grantyb grantyb commented Oct 17, 2013

Fix ngShow and ngHide so they don't animate in/out their classes every time the watch expression is evaluated. These directives now only change when the watch expression's boolean value actually changes.

Closes #4401

…ir classes every time the watch expression is evaluated. They now only change when the watch expression's boolean value actually changes.

This is to address issue #4401
@mary-poppins
Copy link

Thanks for the PR!

  • Contributor signed CLA now or in the past
    • If you just signed, leave a comment here with your real name
  • PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@grantyb
Copy link
Author

grantyb commented Oct 17, 2013

Thanks Mary :-) I just signed a CLA - My full name is Grant Berridge.
I also updated the commit message. I hope it now fulfils the requirements.

@matsko
Copy link
Contributor

matsko commented Oct 23, 2013

Replaced by: #4612

My reasoning is explained here: #4401 (comment)

@matsko matsko closed this Oct 23, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ngShowDirective adds the ng-hide-remove class when the element is already shown
3 participants