This repository was archived by the owner on Apr 12, 2024. It is now read-only.
feat($q): add Promise.progress shorthand for notifyCallbacks #4501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shorthand method for $q promises that allows attaching a progress callback. Provides the same type of convenience as the existing catch shorthand method, and matches functionality existing in the Q library. This should resolve the only remaining concern addressed in angular#1998 Closes angular#1998
|
Thanks for the PR!
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
|
Name for the CLA: Chris Rhoden |
|
We'll see about adding this after 1.2 is released. |
|
Oh man, I was just looking for this on the Angular docs today. Is this PR good to merge? |
petebacondarwin
force-pushed
the
master
branch
from
02dc2aa to
fd2d6c0
Compare
jeffbcross
force-pushed
the
master
branch
2 times, most recently
from
cad9560 to
f294244
Compare
jeffbcross
force-pushed
the
master
branch
4 times, most recently
from
e8dc429 to
e83fab9
Compare
petebacondarwin
force-pushed
the
master
branch
from
4dd5a20 to
998c61c
Compare
|
The |
|
+1 |
|
@pkozlowski-opensource removing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shorthand method for $q promises that allows attaching a progress
callback. Provides the same type of convenience as the existing
catch shorthand method, and matches functionality existing in the Q
library.
This should resolve the only remaining concern addressed in #1998
Closes #1998