Fixing possible bug in initialization of value

[ghost]

Hello, I think I found a bug in initialisation of value value in angular-resource.js.

I tried to fetch a Json array from my Api server and was getting the following error:

TypeError: Object #<Resource> has no method 'push'

I compared code from v1.0.6 (which is working okay) with the code from v1.2.0-rc.3 and found the following difference:

v1.0.6:
var value = this instanceof Resource ? this : (action.isArray ? [] : new Resource(data));

v1.2.0-rc.3:
var isInstanceCall = data instanceof Resource;
var value = isInstanceCall ? data : (action.isArray ? [] : new Resource(data));

And indeed, data is the second parameter to the Resource[name] = function(a1, a2, a3, a4) which is called from Resource.prototype['$' + name] = function(params, success, error) as:

var result = Resource[name](params, this, success, error);

So this in the scope of Resource.prototype will, presumably, be always instance of Resource and var isInstanceCall = data instanceof Resource; will be always set to true.

I am, most likely, wrong, but the following change fixed my problem. I think it is worth for someone from the team to take a look at what is going in there.

[mary-poppins]

Thanks for the PR!

• Contributor signed CLA now or in the past
  • If you just signed, leave a comment here with your real name
• PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

[petebacondarwin]

@sanyax7 - Can you provide a unit test that demonstrates this problem that you are fixing? Also can you ensure that you have signed the CLA?
Thanks

[smashercosmo]

I made a plunker that illustrates this regression.
http://plnkr.co/edit/Eply3y7h3xDjTInZY0SI?p=preview

[tbosch]

Hello @smashercosmo, I looked at your example.

It shows that calling DataResource.save(item) does not return a new DataResrouce object (but a promise instead). This is the same behavior as calling item.$save(). However, in our docs (http://docs.angularjs.org/api/ngResource.$resource) there is the sentence: "Class actions return empty instance (with additional properties below). Instance actions return promise of the action."

So you would expect calling DataResource.save(item) to return a new DataResource, and calling item.$save() to return a promise, right?

[tbosch]

I looked at your PR also. This is the first step, but we also need to set this to the correct value when calling Resource[name] from a prototype method. Se we need

1. var isInstanceCall = this instanceof Resource; instead of var instanceCall = data instanceof Resource in https://github.com/angular/angular.js/blob/master/src/ngResource/resource.js#L442
2. var result = Resource[name].call(this, params, this, success, error); instead of var result = Resource[name](params, this, success, error); in https://github.com/angular/angular.js/blob/master/src/ngResource/resource.js#L525:

This change was introduced by this commit: 05772e1

[tbosch]

I created a pull request for this that also includes a test.

Thanks for filing this PR!

[smashercosmo]

@tbosch

So you would expect calling DataResource.save(item) to return a new DataResource, and calling item.$save() to > > return a promise, right?

yes, this is the exact behaviour, that I expect

P.S. Thanks for proper PR

[ghost]

Thank you for fixing this :)