Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix(ngAnimate): fix cancelChildAnimations throwing exception #4586

Conversation

gregolsky
Copy link
Contributor

fix ngAnimate throwing exception in cancelChildAnimations on deletion of
element (ngAnimate's leave decorator) of repeated element when using
ng-include on this element.

Closes #4548

fix ngAnimate throwing exception in cancelChildAnimations on deletion of
element (ngAnimate's leave decorator) of repeated element when using
ng-include on this element.

Closes angular#4548
@mary-poppins
Copy link

Thanks for the PR!

  • Contributor signed CLA now or in the past
    • If you just signed, leave a comment here with your real name
  • PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@gregolsky
Copy link
Contributor Author

My real name: Grzegorz Lachowski

@matsko
Copy link
Contributor

matsko commented Oct 22, 2013

Testing the code against a CI server now.

@gregolsky
Copy link
Contributor Author

Not sure if I've done something wrong, but it says "The Travis CI build failed". Anything I need to do about it?

@matsko
Copy link
Contributor

matsko commented Oct 22, 2013

Travis sometimes breaks. I'm testing it against the custom AngularJS CI server right now.

@matsko
Copy link
Contributor

matsko commented Oct 22, 2013

Landed as b9557b0

@matsko
Copy link
Contributor

matsko commented Oct 22, 2013

Great work!

@matsko matsko closed this Oct 22, 2013
@gregolsky
Copy link
Contributor Author

Thanks for your help :) This was fun!

@gregolsky gregolsky deleted the fix-animate-cancel-child-animations branch November 10, 2013 21:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ngAnimate throws exception in cancelChildAnimations on deletion of repeated element when using ng-include
3 participants