Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Allow blob urls in images #4623

Closed
wants to merge 1 commit into from
Closed

Allow blob urls in images #4623

wants to merge 1 commit into from

Conversation

mcfedr
Copy link

@mcfedr mcfedr commented Oct 24, 2013

Urls created using URL.createObjectURL are currently marked unsafe, lets fix this.

see #3889

@mary-poppins
Copy link

Thanks for the PR!

  • Contributor signed CLA now or in the past
    • If you just signed, leave a comment here with your real name
  • PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@petebacondarwin
Copy link
Contributor

You can override this yourself, in the meantime, inside a module.config block. See http://docs.angularjs.org/api/ng.$compileProvider#methods_imgsrcsanitizationwhitelist

@mcfedr
Copy link
Author

mcfedr commented Nov 12, 2013

thanks, this is what i have done.

@IgorMinar
Copy link
Contributor

I'm sorry, but I wasn't able to verify your CLA signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let me know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@mcfedr
Copy link
Author

mcfedr commented Dec 9, 2013

I thought I had signed it, I have done it again in any case,

@geelen
Copy link

geelen commented Jan 5, 2014

Has anything changed with this PR in the last month? The workaround described works fine but it seems like a reasonable new default.

Urls created using URL.createObjectURL were previously blocked
and marked as unsafe
@mcfedr
Copy link
Author

mcfedr commented Jan 16, 2014

I have changed the commit to fix the typo.

@benbenwilde
Copy link

+1 this would be nice

@schmod
Copy link
Contributor

schmod commented Feb 18, 2014

would love to see this in the release.

@ricricucit
Copy link

+1

@IgorMinar
Copy link
Contributor

@mcfedr I reimplemented this one because your PR was too stale and didn't contain tests.

thanks for bringing this to our attention though.

@joeriks
Copy link

joeriks commented Apr 16, 2014

phonegap on android can have images on "content://..." so it would perhaps be a good idea to add content in the whitelist aswell.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants