Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

WIP fix($compile): don't instantiate controllers twice for element transclud... #4654

Closed
wants to merge 2 commits into from
Closed

WIP fix($compile): don't instantiate controllers twice for element transclud... #4654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d0b630
style(compileSpec): reorder and cleanup tests for $compile's transclu…
IgorMinar Oct 26, 2013
1798ac2
fix($compile): don't instantiate controllers twice for element transc…
IgorMinar Oct 26, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/ng/compile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1191,9 +1191,13 @@ function $CompileProvider($provide) {

childTranscludeFn = compile($template, transcludeFn, terminalPriority,
replaceDirective && replaceDirective.name, {
controllerDirectives: controllerDirectives,
newIsolateScopeDirective: newIsolateScopeDirective,
templateDirective: templateDirective,
// Don't pass in:
// - controllerDirectives - otherwise we'll create duplicates controllers
// - newIsolateScopeDirective or templateDirective - combining templates with
// element transclusion doesn't make sense.
//
// We need only transcludeDirective so that we prevent putting transclusion
// on the same element more than once.
transcludeDirective: transcludeDirective
});
} else {
Expand Down
Loading