This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(input): re-evaluate value if min/max changed #4788
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if (attr.min || attr.max) { | ||
| scope.$watch( | ||
| function() { return attr.min + '' + attr.max; }, |
There was a problem hiding this comment.
This optimisation could fail if max and min changed at the same time in such a way that max+''+min stayed the same:
22 + '' + 23 == '2223'
2 + '' + 223 == '2223'
Admittedly, this is a highly unusual and contrived case but the performance improvement is not going to be so great (if at all) to warrant it.
|
Given the optimization comment above and that |
|
Agreed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Value was not re-evaluated when min/max changed.