This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(nodeName_): always return lowercase #4932
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #3987. Changed nodeName_ to always return lowercase. Changed code directly using .nodeName to use nodeName() instead.
| @@ -33,7 +33,7 @@ | |||
| var y = eventData.y; | |||
|
|
|||
| var inputType = (element.type) ? element.type.toLowerCase() : null, | |||
| nodeName = element.nodeName.toLowerCase(); | |||
| nodeName = nodeName_(element); | |||
There was a problem hiding this comment.
the ngScenario module does not have access to private functions in angular.js, they're wrapped in a closure so it can't see them.
ghost
assigned 
|
@yuri0 - can you ensure that you have signed the CLA? Thanks |
|
@caitp - other than the issue with ngScenario, does this PR look good to you? |
|
Landed as dafb8a3 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3987. Change nodeName_ to always return lowercase. Change code
directly using .nodeName to use nodeName() instead.