Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Animate fixes #5015

Closed
wants to merge 5 commits into from
Closed

Animate fixes #5015

wants to merge 5 commits into from

Commits on Nov 22, 2013

  1. fix($compile): ensure CSS classes are added and removed only when nec… 

    …essary

When $compile interpolates a CSS class attribute expression it will
do so by comparing the CSS class value already present on the element.
This may lead to unexpected results when dealing with ngClass values being
added and removed therefore it is best that both compile and ngClass delegate
addClass/removeClass operations to the same block of code.
    @matsko
    matsko committed Nov 22, 2013
    Configuration menu
    Copy the full SHA
    db8e6c6 View commit details
    Browse the repository at this point in the history

  2. fix($animate): ensure addClass/removeClass animations do not snap dur… 

    …ing reflow

Closes angular#4892
    @matsko
    matsko committed Nov 22, 2013
    Configuration menu
    Copy the full SHA
    583e299 View commit details
    Browse the repository at this point in the history

  3. fix($animate): ensure transition animations are unblocked before the … 

    …dom operation occurs

Transitions are blocked when the base CSS class is added at the start of the animation. This
causes an issue if the followup CSS class contains animatable-styles. Now, once the animation
active state is triggered (when the animation CSS dom operation occurs) the animation itself
will always trigger an animate without a quick jump.

Closes angular#5014
Closes angular#4265
    @matsko
    matsko committed Nov 22, 2013
    Configuration menu
    Copy the full SHA
    6b361a1 View commit details
    Browse the repository at this point in the history

  4. fix($animate): ensure keyframe animations are blocked around the reflow 

    Keyframe animations trigger on the first CSS class and not the second.
This may cause a slight flicker during a stagger animation since the
animation has already started before the stagger delay is considered.
This fix ensures that the animation is blocked until the active animation
starts which allows for staggering animations to take over properly.

Closes angular#5018
    @matsko
    matsko committed Nov 22, 2013
    Configuration menu
    Copy the full SHA
    523fd16 View commit details
    Browse the repository at this point in the history

  5. chore($animate): remove unnecessary reflective dereferencing

    @matsko
    matsko committed Nov 22, 2013
    Configuration menu
    Copy the full SHA
    b05d259 View commit details
    Browse the repository at this point in the history