-
Notifications
You must be signed in to change notification settings - Fork 27.4k
Conversation
Thanks for the PR!
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
i just signed the CLA with real name: Bart van den Burg |
Very similar to #4791 |
@petebacondarwin This is not actually the same. #4791 handles interpolation of fields names, this PR handles interpolation of form names. |
Sorry, I see. |
I'm sorry, but I wasn't able to verify your CLA signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let me know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
@IgorMinar I noticed I used another e-mail address for the commit than for the CLA. I've changed the commit to show the correct e-mail address |
Any word on this pr or the status of the CLA? Very useful functionality when dynamically creating non-trivial nested forms (subforms using ngForm). cheers |
+1 |
1 similar comment
👍 |
+1..we need it also. |
So until this feature will be pushed, if will be, we are going to extend the form with a new directive just to add this feature into them: http://plnkr.co/TgRL1nJ6h24IfX80uZpk |
02dc2aa
to
fd2d6c0
Compare
cad9560
to
f294244
Compare
e8dc429
to
e83fab9
Compare
This was introduced in 729c238 |
This PR, in addition to #2988, will also interpolate the value in the form name. Especially useful when adding a collection of forms based on an array.
It'd be especially neat if the commented version of the code could work, but I'm not sure how to make this work.