Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

feat(form): interpolate form names #5231

Closed
wants to merge 1 commit into from

Conversation

Burgov
Copy link

@Burgov Burgov commented Dec 2, 2013

This PR, in addition to #2988, will also interpolate the value in the form name. Especially useful when adding a collection of forms based on an array.

It'd be especially neat if the commented version of the code could work, but I'm not sure how to make this work.

@mary-poppins
Copy link

Thanks for the PR!

  • Contributor signed CLA now or in the past
    • If you just signed, leave a comment here with your real name
  • PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@Burgov
Copy link
Author

Burgov commented Dec 2, 2013

i just signed the CLA with real name: Bart van den Burg

@petebacondarwin
Copy link
Contributor

Very similar to #4791

@Burgov
Copy link
Author

Burgov commented Dec 2, 2013

@petebacondarwin This is not actually the same. #4791 handles interpolation of fields names, this PR handles interpolation of form names.

@petebacondarwin
Copy link
Contributor

Sorry, I see.

@IgorMinar
Copy link
Contributor

I'm sorry, but I wasn't able to verify your CLA signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let me know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@Burgov
Copy link
Author

Burgov commented Dec 7, 2013

@IgorMinar I noticed I used another e-mail address for the commit than for the CLA. I've changed the commit to show the correct e-mail address

@grimwinoleader
Copy link

Any word on this pr or the status of the CLA? Very useful functionality when dynamically creating non-trivial nested forms (subforms using ngForm). cheers

@plentz
Copy link
Contributor

plentz commented May 28, 2014

+1

1 similar comment
@elado
Copy link

elado commented May 28, 2014

👍

@vadimpopa
Copy link

+1..we need it also.

@vadimpopa
Copy link

So until this feature will be pushed, if will be, we are going to extend the form with a new directive just to add this feature into them: http://plnkr.co/TgRL1nJ6h24IfX80uZpk

@Narretz
Copy link
Contributor

Narretz commented Oct 13, 2014

This was introduced in 729c238

@Narretz Narretz closed this Oct 13, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants