Clarified that ngSwitchWhen acceptable expressions must be a text litera...

[gdennie]

...l

The matchValue is not arbitrary but must be text. In particular, it cannot even be an expression or handle-barred expression resulting in text.

[mary-poppins]

Thanks for the PR!

• Contributor signed CLA now or in the past
  • If you just signed, leave a comment here with your real name
• PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

[IgorMinar]

I'm sorry, but I wasn't able to verify your CLA signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let me know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

[petebacondarwin]

@gdennie - thanks for this suggestion. I didn't find simply changing the attribute values that clear. So I have added an info box clarifying what can go into a ng-switch-when attribute. See 9396d55

[gdennie]

Hi Pete,

Nice. A few notes…

I do not recommend using the word, “without,” but rather “outside of the.” It is more words to type but the convention makes reading and comprehension less effortful.

I believe ng-switch works like ng-if to add and remove elements from the DOM. Consequently, the term, “If a matching expression is not found… an element with the default * attribute is displayed.” is incorrect since the added element need not be visible.

Keep up the good work.

George.

From: Pete Bacon Darwin [mailto:notifications@github.com]
Sent: December 12, 2013 6:45 AM
To: angular/angular.js
Cc: gdennie
Subject: Re: [angular.js] Clarified that ngSwitchWhen acceptable expressions must be a text litera... (#5285)

@gdennie https://github.com/gdennie - thanks for this suggestion. I didn't find simply changing the attribute values that clear. So I have added an info box clarifying what can go into a ng-switch-when attribute. See 9396d55 9396d55

—
Reply to this email directly or view it on GitHub #5285 (comment) .Image removed by sender.