-
Notifications
You must be signed in to change notification settings - Fork 27.4k
chore(CHANGELOG): introduce perf() section for performance-related commits #5312
Conversation
Hi Matias! |
lgtm. please also update the commit message conventions doc linked from Contributing doc |
…mmits Instead of using fix() or chore() when labelling a commit which improves speed or performance use perf(). Perf commits will be listed in the CHANGELOG under "Performance Improvements". For example: perf($animate): cache all getComputedStyle operations to reduce additional reflows
@IgorMinar done. |
And the https://github.com/angular/angular.js/blob/master/validate-commit-msg.js and its spec. |
BTW, I always assumed that such performance related commits went under "refact"? |
I'm sorry, but I wasn't able to verify your CLA signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let me know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
This would be great. I submitted a PR labeled I can imagine that this PR didn't get much attention because of this Having such things labeled as |
Can't this be included in |
We thought about that, but I believe |
@IgorMinar @petebacondarwin done (both of them). |
MERGED |
Landed as a14266e |
just stumbled upon this google doc: https://docs.google.com/document/d/1QrDFcIiPjSLDn3EL15IJygNPiHORgU1_OOAqWjiDU5Y/edit?pli=1 (Git Commit Message Conventions |
Instead of using fix() or chore() when labelling a commit which improves
speed or performance use perf(). Perf commits will be listed in the
CHANGELOG under "Performance Improvements".
For example:
perf($animate): cache all getComputedStyle operations to reduce additional reflows