Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs($http): remove outdated part about $http outside of $apply phase #5485

Closed
wants to merge 1 commit into from

Conversation

cburgdorf
Copy link
Contributor

This removes some outdated advice which no longer is true against the latest angular version.

Relates to #5206

This removes some outdated advice which no longer is true against the latest angular version.

Relates to angular#5206
@IgorMinar
Copy link
Contributor

I'm sorry, but I wasn't able to verify your CLA signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let me know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@cburgdorf
Copy link
Contributor Author

I actually signed it in the past but I just signed it again (Christoph Burgdorf)

@IgorMinar
Copy link
Contributor

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@caitp caitp closed this in 6c9131e Jan 19, 2014
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
This removes some outdated advice which no longer is true against the latest angular version.

The information about unit testing with ngMocks remains, because it's always good to have
information like that easily found. This little snippet is not worded perfectly, and is not
a very good example unit test, so additional work is needed here.

Relates to angular#5206
Closes angular#5485
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
This removes some outdated advice which no longer is true against the latest angular version.

The information about unit testing with ngMocks remains, because it's always good to have
information like that easily found. This little snippet is not worded perfectly, and is not
a very good example unit test, so additional work is needed here.

Relates to angular#5206
Closes angular#5485
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants