This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($q): pass promise-aplus-tests v2.0.3 WIP #5536
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGES In compliance with the promise spec, fulfilling or rejecting a promise with itself will throw a TypeError (2.3.1. http://promisesaplus.com/#point-57)
|
Clearly a lot of the tests have broken with this change, whether it's related entirely to ngMocks, or something else, I'm not sure. I'll figure that out over the next week or so |
ghost
assigned
|
@wizardwerdna any comments on this yet? I'll take another look tomorrow but I expect you'll have some insight on ways to improve this. |
|
Closing in favour of #5976 --- Will come back to this to try and improve performance down the line |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a work in progress, but this implementation is now passing the
full promises-aplus-tests v2.0.3.
It is still necessary to shrink this down and hopefully provide a better
flyweight/prototype-based implementation.
Fixes #5223