docs($sce): clean up the docs #5551
Conversation
|
I'm sorry, but I wasn't able to verify your CLA signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let me know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
|
I know I've signed it, but it must have been with another email address. I signed it again with this email address. |
|
CLA signature verified! Thank you! Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes). |
|
Could you squash these and format the commit messages according to the commit message conventions so that when this gets merged nobody has to amend it? Thanks a bunch~ Also, re: your third commit, it appears to be incorrect. http://plnkr.co/edit/WQ8Q8h5HDsIOFluTaD26?p=preview shows that the constant HTML literal is actually trusted... Unless you mean without using ngSanitize |
|
@caitp Yeah... I'm starting to really confuse myself. This started out as, "Hey, there are references to a directive that no longer exists," and it quickly turned into me making a mess of things, haha. Ok, so re-reading the docs, it is very unclear that (No wonder I'm so confused!) I am gonna see what I can do to try and clean this doc up (if I can make sure I can understand this properly) and clean up this PR. |
|
@caitp Ok, so this was my first experience at squashing (or rebasing anything). It was exciting... and I think I got it right! Anyway, I am not 100% sure the complete impact of |
Include mention of `ngSanitize` (and add it to the example), as well as removing (and clarifying if needed) references to `ng-html-bind-unsafe`.
ghost
assigned 
|
It would have been good to merge this a few releases ago! It passes tests and the docs look good locally, so this is nice, thanks |
|
Haha, it's okay. Just glad I could help. I had a buddy ask about binding HTML, and we started going through the docs, and couldn't've been more confused. Finally figured out it was out of date docs! |
Include mention of `ngSanitize` (and add it to the example), as well as removing (and clarifying if needed) references to `ng-html-bind-unsafe`. Closes angular#5551
Include mention of `ngSanitize` (and add it to the example), as well as removing (and clarifying if needed) references to `ng-html-bind-unsafe`. Closes angular#5551
Include mention of
ngSanitize(and add it to the example), as well as removing (and clarifying if needed) references tong-html-bind-unsafe.