Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Update route.js #5614

Closed
wants to merge 1 commit into from
Closed

Update route.js #5614

wants to merge 1 commit into from

Conversation

yentheo
Copy link

@yentheo yentheo commented Jan 3, 2014

feat(ngRoute): change

This change adds a new event on ngRoute called beforeRouteChange. With this change it is possible to cancel a locationChange based on route data. The problem that I am trying to fix here is described in #5581

With this change it is possible to cancel a locationChange based on route data. The problem that I am trying to fix here is described in #5581
@yentheo
Copy link
Author

yentheo commented Jan 3, 2014

Well the build failed because of the comments being too long. Don't know how to make a new commit with the comments made shorter though.

@IgorMinar
Copy link
Contributor

I'm sorry, but I wasn't able to verify your CLA signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let me know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@yentheo
Copy link
Author

yentheo commented Jan 3, 2014

I've signed the CLA, before I commited, I suppose it's still being processed

@Narretz
Copy link
Contributor

Narretz commented Jan 3, 2014

you can check how to add a commit here https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md
You should also adjust the commit message

@yentheo
Copy link
Author

yentheo commented Jan 3, 2014

Do I need to do a new PR from the original branch? Can't I just change my original commit an create a new commit for that change?

@ghost ghost assigned tbosch Jan 4, 2014
@tbosch
Copy link
Contributor

tbosch commented Jan 4, 2014

You can use git rebase.

@yentheo yentheo closed this Jan 5, 2014
@yentheo yentheo deleted the patch-1 branch January 5, 2014 15:25
@yentheo yentheo restored the patch-1 branch January 5, 2014 15:26
@yentheo yentheo deleted the patch-1 branch January 17, 2014 10:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants