Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Document difference between ng-change and JavaScript onchange #5640

Closed
wants to merge 1 commit into from
Closed

Document difference between ng-change and JavaScript onchange #5640

wants to merge 1 commit into from

Conversation

andreas-gruenbacher
Copy link
Contributor

The ng-change event triggers immediately, which makes a difference for text input fields and text areas, where the JavaScript onchange event would only be called at the end of the change.

The ng-change event triggers immediately, which makes a difference for text input fields and text areas, where the JavaScript onchange event would only be called at the end of the change.
@IgorMinar
Copy link
Contributor

I'm sorry, but I wasn't able to verify your CLA signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let me know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@andreas-gruenbacher
Copy link
Contributor Author

2014/1/5 Igor Minar notifications@github.com

I'm sorry, but I wasn't able to verify your CLA signature. CLA signature
is required for any code contributions to AngularJS.

I've signed the online CLA (even though I find it irritating).

@IgorMinar
Copy link
Contributor

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@ghost ghost assigned jeffbcross Jan 7, 2014
@caitp caitp closed this in 5adea0b Jan 17, 2014
@caitp
Copy link
Contributor

caitp commented Jan 17, 2014

@andreas-gruenbacher I had to revert your changes to the example code because it broke the scenario tests, but if you think your changes made the example easier to understand, please submit a subsequent update to the example which also addresses the e2e scenario as well

jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
The ng-change event triggers immediately, which makes a difference for text input fields and text
areas, where the JavaScript onchange event would only be called at the end of the change.

Closes angular#5640
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
The ng-change event triggers immediately, which makes a difference for text input fields and text
areas, where the JavaScript onchange event would only be called at the end of the change.

Closes angular#5640
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants