refactor(input): wrapped validation logic in helper function

[bwiklund]

I feel this makes the code more readable, but I suppose that's debatable. It cuts 476b off .min and 72b off .min.gz

Also included:

I moved var min = parseFloat(attr.min); and var max = parseFloat(attr.max); out of their validation function, since they only need to be evaluated once.

I renamed the regex helper function form validate to validateRegex and moved it inside the if block that uses it.

If you'd like these split up into separate PR's I can do that.

[bwiklund]

One sec, fixing e2e test failure

[bwiklund]

Actually, I'm getting that failure angular+jqlite api/ng.directive:input should be invalid if less than required min length on master branch as well. Any idea what's up?

[gsklee]

@bwiklund your change has broken the e2e tests here: https://github.com/angular/angular.js/blob/master/src/ng/directive/input.js#L800

[bwiklund]

Fixed

[IgorMinar]

you can't move this out of the validator fn because we need to reparse the value on each validation

[IgorMinar]

I made a few small changes and fix the parsing bug. I'm testing it on CI and will merge it in if green

[bwiklund]

Sounds good. I noticed that there's no unit test to pick up that minlength bug that only showed up at the end of test:e2e. Worth my time to make a PR for that?

[IgorMinar]

@bwiklund yes please! that would be awesome. I'm surprised that we didn't have a test for it.

[IgorMinar]

thanks for this pr

[bwiklund]

👍