bug($ng): change numberInputType to check for leading decimals #5682

joeenzminger · 2014-01-08T15:23:33Z

add check for leading decimal. Some browsers swallow leading decimals on
input type="number".

add check for leading decimal. Some browsers swallow leading decimals on input type="number". fixes angular#5680

IgorMinar · 2014-01-08T16:13:17Z

I'm sorry, but I wasn't able to verify your CLA signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let me know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

joeenzminger · 2014-01-08T16:28:06Z

CLA Updated to match my GitHub email address

IgorMinar · 2014-01-08T17:13:01Z

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

tbosch · 2014-01-09T00:40:51Z

Hi,
thanks! Could you also add a unit test for this?

anton000 · 2014-02-11T06:04:11Z

status of this?

caitp · 2014-02-11T06:19:28Z

test/ng/directive/inputSpec.js

@@ -409,1064 +409,1070 @@ describe('ngModel', function() {
 });


-describe('input', function() {


It looks like your IDE screwed up indentation in this file, could you fix that? Should be two spaces.

caitp · 2014-02-11T06:32:13Z

@joeenzminger, can you explain what is meant by "swallow leading decimals" for me? This change only modifies values which are exactly one period, and I'm not sure I see why a single '.' shouldn't be NaN.

Now, if this affects more legitimate values, the right fix might be a change to the regexp instead -- actually, looks like the regexp deals with leading periods already.

I'm not sure this really fixes anything, so if you can provide info on the exact problem, I'll be happy to take another look

caitp · 2014-02-11T06:47:46Z

test/ng/directive/inputSpec.js

+        it('should allow "." in input element', function () {
+            compileInput('<input type="number" ng-model="price" />');
+            changeInputValueTo('.');
+            expect(inputElm.val()).toBe('.');


A '.' is not a real number, as far as I'm aware. It's also a badInput in modern browsers, which means the value would be the empty string if a user typed it.

anton000 · 2014-02-11T07:44:58Z

@caitp I think he means it doesn't allow the first keyboard entry to be a "." . i.e When entering a decimal value, users usually omit the leading 0 on input, .1234 instead of 0.1234. input [number] seems to reject this type of entry in some browsers.

joeenzminger · 2014-02-11T15:35:38Z

@caitp - the fix attempt in the PR is not valid (for all browsers anyway). I think I'll pull the PR and submit another one later, but the bug is still valid. I'll also fix the indentation issues.

While '.' is a badInput for type="number", without angular, browsers don't "swallow" it. They continue to display it (even while reporting value as 0 or "") in anticipation of the user continuing to add new characters (and thus making the input valid). With angular, on some browsers, you can't even type the '.', so it is impossible to enter a decimal number unless you first enter a leading 0, etc. This is not very intuitive for most users.

I am also a little stuck on writing a test that validates the fix, since there really isn't a way to validate that affected browsers are displaying the "." with the fix applied (they still report 0 or "" as their value).

caitp · 2014-02-11T15:56:56Z

Ah I see, you're right, FF26 is broken in this way.

halloffame · 2014-03-05T00:44:02Z

There's a SO question about this http://stackoverflow.com/questions/20985443/entering-number-with-leading-decimal-in-angular-input-type-number.

And here's a jsFiddle demo of the issue http://jsfiddle.net/NEhG9/3/

tbosch · 2014-08-04T15:00:14Z

Hi,
we could also try to use input.valueAsNumber for reading out the current value from the browser, instead of reading input.value and the parsing it ourselves...

caitp · 2014-12-03T19:48:16Z

I'm not able to reproduce this anymore in any version of angular I've tried with, in FF33. I think we can close this? Please re-open if this is still an issue.

ghost · 2016-07-15T12:06:39Z

Still facing this issue with angular 1.5.7 and FF 47.0.1.

gkalpak · 2016-07-15T18:20:02Z

@credifiable, this issue has been closed. If you still see the problem, please open a new issue providing a live reproduction (e.g. using CodePen, Plnkr etc).

jjravleuven · 2017-06-18T22:08:34Z

why is this issue closed? it's clearly not dealt with...

gkalpak · 2017-06-18T22:25:56Z

@jamesvanleuven, the issue is still open: #5680

bug($ng): change numberInputType to check for leading decimals

58ac268

add check for leading decimal. Some browsers swallow leading decimals on input type="number". fixes angular#5680

ghost assigned tbosch Jan 9, 2014

Joe Enzminger added 3 commits January 9, 2014 09:33

added unit test for issue 5680

8370fc7

modified unit test to be more specific

2aa80e8

removed checks for element validity and value

a459ec4

caitp reviewed Feb 11, 2014
View reviewed changes

caitp self-assigned this Feb 11, 2014

caitp reviewed Feb 11, 2014
View reviewed changes

tbosch mentioned this pull request Aug 4, 2014

Forms validation refactoring #6928

Closed

btford removed the gh: PR label Aug 20, 2014

caitp force-pushed the master branch from 591bac5 to d713ad1 Compare August 22, 2014 13:50

tbosch force-pushed the master branch from 6c27b89 to 271572c Compare August 30, 2014 00:57

tbosch force-pushed the master branch from a3d7934 to 1418383 Compare September 10, 2014 18:14

petebacondarwin force-pushed the master branch from 02dc2aa to fd2d6c0 Compare September 16, 2014 11:25

jeffbcross force-pushed the master branch 2 times, most recently from cad9560 to f294244 Compare October 2, 2014 22:08

btford force-pushed the master branch from 9011a65 to 46db47b Compare October 6, 2014 22:54

jeffbcross force-pushed the master branch 2 times, most recently from abdaab7 to 30996f8 Compare October 8, 2014 19:46

jeffbcross force-pushed the master branch 2 times, most recently from e8dc429 to e83fab9 Compare October 10, 2014 17:37

petebacondarwin force-pushed the master branch from 4dd5a20 to 998c61c Compare October 19, 2014 10:57

caitp closed this Dec 3, 2014

ghost unassigned caitp Jul 15, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bug($ng): change numberInputType to check for leading decimals #5682

bug($ng): change numberInputType to check for leading decimals #5682

joeenzminger commented Jan 8, 2014

IgorMinar commented Jan 8, 2014

joeenzminger commented Jan 8, 2014

IgorMinar commented Jan 8, 2014

tbosch commented Jan 9, 2014

anton000 commented Feb 11, 2014

caitp Feb 11, 2014

caitp commented Feb 11, 2014

caitp Feb 11, 2014

anton000 commented Feb 11, 2014

joeenzminger commented Feb 11, 2014

caitp commented Feb 11, 2014

halloffame commented Mar 5, 2014

tbosch commented Aug 4, 2014

caitp commented Dec 3, 2014

ghost commented Jul 15, 2016

gkalpak commented Jul 15, 2016 •

edited

Loading

jjravleuven commented Jun 18, 2017

gkalpak commented Jun 18, 2017

		@@ -409,1064 +409,1070 @@ describe('ngModel', function() {
		});


		describe('input', function() {

bug($ng): change numberInputType to check for leading decimals #5682

bug($ng): change numberInputType to check for leading decimals #5682

Conversation

joeenzminger commented Jan 8, 2014

IgorMinar commented Jan 8, 2014

joeenzminger commented Jan 8, 2014

IgorMinar commented Jan 8, 2014

tbosch commented Jan 9, 2014

anton000 commented Feb 11, 2014

caitp Feb 11, 2014

Choose a reason for hiding this comment

caitp commented Feb 11, 2014

caitp Feb 11, 2014

Choose a reason for hiding this comment

anton000 commented Feb 11, 2014

joeenzminger commented Feb 11, 2014

caitp commented Feb 11, 2014

halloffame commented Mar 5, 2014

tbosch commented Aug 4, 2014

caitp commented Dec 3, 2014

ghost commented Jul 15, 2016

gkalpak commented Jul 15, 2016 • edited Loading

jjravleuven commented Jun 18, 2017

gkalpak commented Jun 18, 2017

gkalpak commented Jul 15, 2016 •

edited

Loading