This repository was archived by the owner on Apr 12, 2024. It is now read-only.
#5001: Fixes jqLite not correctly adding & removing classes in IE9 #5686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first step in migrating tests from <doc:scenario> to <doc:protractor>. In-documentation examples with doc:protractor sections will have their contents output to a tab on the docs site as well as output to a standalone test file in build/docs/ptore2e.
ghost
assigned 
|
can you also add a test for the original issue please? |
…s into jqlite_ie9_class_fix
|
you shouldn't merge stuff into this branch/PR otherwise the diff is a mess (as it is now). please see our contributing instructions for how to avoid these problems: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md |
|
I figured the diff is a mess - shall I close this one and open another one once I clean this up? The thing is that it's a bit troublesome getting the tests to run on IE9 without taking advantage of Travis here. |
|
Attempt no. 3 (#5694) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a condensed version of #5669 that does not break the tests.