Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Update step_02.ngdoc #5697

Closed
wants to merge 1 commit into from
Closed

Update step_02.ngdoc #5697

wants to merge 1 commit into from

Conversation

sethstone
Copy link
Contributor

Fixed 1st code snippet under experiments to agree with the second step.

Fixed 1st code snippet under experiments to agree with the second step.
@IgorMinar
Copy link
Contributor

I'm sorry, but I wasn't able to verify your CLA signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let me know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@sethstone
Copy link
Contributor Author

Sorry about that, I took care of it just now.

On Wed, Jan 8, 2014 at 10:14 PM, Igor Minar notifications@github.comwrote:

I'm sorry, but I wasn't able to verify your CLA signature. CLA signature
is required for any code contributions to AngularJS.

Please sign our CLAhttps://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#signing-the-claand ensure
that the CLA signature email address and the email address in this PR's
commits match
.

If you signed the CLA as a corporation, please let me know the company's
name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses
don't match. Please sign the CLA again or update the email address in the
commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA
verification process.


Reply to this email directly or view it on GitHubhttps://github.com//pull/5697#issuecomment-31901503
.

@IgorMinar
Copy link
Contributor

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@ghost ghost assigned IgorMinar Jan 10, 2014
@IgorMinar
Copy link
Contributor

but that would mean that the example would result in nothing being displayed because the model is created only later.

I'm going to change your commit to leave the first experiment as is and add instructions for adding the hello binding to the second experiment

@IgorMinar IgorMinar closed this in 69452fa Jan 10, 2014
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants