This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs(versions): preserve URL path. Fixes #4661 #5773
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preserve URL path when switching between doc versions. Fixes angular#4661
ghost
assigned
|
|
||
| // preserve URL path when switching between doc versions | ||
| if (angular.isObject($rootScope.currentPage) && $rootScope.currentPage.section && $rootScope.currentPage.id) { | ||
| currentPagePath = '/' + $rootScope.currentPage.section + '/' + $rootScope.currentPage.id; |
There was a problem hiding this comment.
why not use $location.path()?
|
@petebacondarwin can you merge this please when it's ready? we should preserve this behavior in bike-shed as well. |
|
Will do but of course this will only work on current and future versions. As soon as you navigate to an older version you will lose this facility. |
jamesdaily
pushed a commit
to jamesdaily/angular.js
that referenced
this pull request
Jan 27, 2014
Preserve URL path when switching between doc versions. Closes angular#4661 Closes angular#5773
jamesdaily
pushed a commit
to jamesdaily/angular.js
that referenced
this pull request
Jan 27, 2014
Preserve URL path when switching between doc versions. Closes angular#4661 Closes angular#5773
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preserve URL path when switching between doc versions. Fixes #4661