Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(guide): Add angular-easyfb with Facebook login to login libraries #5792

Closed
wants to merge 1 commit into from
Closed

docs(guide): Add angular-easyfb with Facebook login to login libraries #5792

wants to merge 1 commit into from

Conversation

Urigo
Copy link
Contributor

@Urigo Urigo commented Jan 14, 2014

No description provided.

@btford btford added the gh: PR label Mar 25, 2014
@btford
Copy link
Contributor

btford commented Mar 27, 2014

I haven't looked too much into this library, but I noticed it violates some best practices: pc035860/angular-easyfb#19

If this is resolved, I'd be happy to reconsider adding it to the list.

@btford btford added this to the Purgatory milestone Mar 27, 2014
@btford btford removed the gh: PR label Aug 20, 2014
@jeffbcross jeffbcross force-pushed the master branch 2 times, most recently from cad9560 to f294244 Compare October 2, 2014 22:08
@jeffbcross jeffbcross force-pushed the master branch 4 times, most recently from e8dc429 to e83fab9 Compare October 10, 2014 17:37
@caitp
Copy link
Contributor

caitp commented Jan 6, 2015

It looks like the issue Brian raised has been resolved --- I didn't see it as a huge problem anyways, and that project has a good number of stars. LGTM

caitp pushed a commit that referenced this pull request Jan 6, 2015
@Urigo @caitp
docs(guide/index): add angular-easyfb with Facebook login to login li…
ba9dee1 
…braries

Merci~

Closes #5792
@caitp caitp closed this in d2a9a16 Jan 6, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes needs: work type: docs
Projects
None yet
Milestone
Purgatory
Development

Successfully merging this pull request may close these issues.
3 participants
@Urigo @btford @caitp