added missing function okToGreet

[letsmakesense]

the function okToGreet wasn't defined, so this example wouldn't work properly.

[mary-poppins]

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

[caitp]

Hey, I'm not totally sure this adds a whole lot... I'm not opposed to it necessarily, but I think the okToGreet() function should be defined underneath the asyncGreet() function, just so that the focus is on the original example.

Cool?

[caitp]

Sorry about that, I accidentally referenced the wrong issue... my mistake :[

[letsmakesense]

no problem . the issue isn't that important. just to avoid that more
people stumble upon it.

On Sat, 18 Jan 2014 16:12:13 -0600, Caitlin Potter
notifications@github.com wrote:

Sorry about that, I accidentally referenced the wrong issue... my
mistake :[

---

Reply to this email directly or view it on GitHub:
#5878 (comment)

[caitp]

So, I've decided that I don't think defining this function in the example really adds anything useful to the example, but I think a note could be made of it (that it's expected to be in the lexical scope), does that work for you?

[letsmakesense]

yeah, that's fine, too

On Sat, 18 Jan 2014 16:32:37 -0600, Caitlin Potter
notifications@github.com wrote:

So, I've decided that I don't think defining this function in the
example really adds anything useful to the example, but I think a note
could be made of it (that it's expected to be in the lexical scope),
does that work for you?

---

Reply to this email directly or view it on GitHub:
#5878 (comment)

[letsmakesense]

you could also omit the function completely:

if (okToGreet(name))
< if (name == 'Robin Hood')

to avoid unnecessary boilerplate notes.

On Sat, 18 Jan 2014 16:32:37 -0600, Caitlin Potter
notifications@github.com wrote:

So, I've decided that I don't think defining this function in the
example really adds anything useful to the example, but I think a note
could be made of it (that it's expected to be in the lexical scope),
does that work for you?

---

Reply to this email directly or view it on GitHub:
#5878 (comment)