This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(ng:options): compile null/blank option tag #593
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version was throwing some cryptic
cannot access childNodes property of undefined
when using template in select's blank option.
This one required going really deep down to compiler. Turns out that when
Template
instance is created, it savespaths
to (indexes of) child nodes which are to be compiled, then executes linker functions on given element and then proceeds to it's childNodes.When had ng:options, it removed all from causing
Template
go try linking with unexistent element's childNode.src/widget/select.js
to compile blank option (I tried several options, but this one seems the most natural)Fixes #562