This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Length-based validation + "password" is correct input field type #601
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First I added missing validation method based on field length. I use "minlength" and "maxlength" 's attributes to set min and max value length, and set input.$error.MINLENGTH and input.$error.MAXLENGTH in case field's value is too short/long.
The second commit a fix: <input type="password" /> kept converted to <input type="text" /> by angular.js, which made it effectively useless for forms handling. I added "password" type to the list of correct HTML5 input types