fix (filterFilter): #6098
fix (filterFilter): #6098
Conversation
…ted predicate objects
| @@ -188,7 +188,7 @@ function filterFilter() { | |||
| (function(path) { | |||
| if (typeof expression[path] == 'undefined') return; | |||
| predicates.push(function(value) { | |||
| return search(path == '$' ? value : (value && value[path]), expression[path]); | |||
| return search(path == '$' ? value : ( (value && value[path]) || getter(value, path)), expression[path]); | |||
There was a problem hiding this comment.
this behavior could lead to some pretty interesting collisions.
I think it would be better to use different syntax to distinguish between these two behaviors.
We thought about prefixing path with $ since that is already being used, but it just looks weird:
items | filter: {'$some.deep.path': value}
maybe something like this would be easier to understand:
items | filter: {'path: some.deep.path': value}
but even that looks weird.
another option which is the one that I'm currently preferring is:
items | filter: {some: {deep: {path: value}}}
it's a bit verbose but very explicit - there are no surprises here.
There was a problem hiding this comment.
I agree that the final option is very clear!
Can you elaborate on the collisions? I think the resolution order here is clear:
- If
pathis a dotted property that exists onvalue, use that. - Otherwise, it traverses an object as expected.
Can you give an example of the collisions you're expecting?
Considering that dotted property names are usually linter errors, and generally are artifacts of a serializer, i think you can make the case that nested objects are a much more natural usecase than supporting dotted properties. Whatever that means for an intuitive syntax, though, I don't know :) The last one looks a bit like MongoDB's query language, so maybe it's less surprising than I think.
There was a problem hiding this comment.
{
'some.path': val1,
some: { path: val2
}
object like this could be pretty confusing to work with if we simply used the fallback method.
I agree that it's not common, but I'd rather avoid it altogether.
|
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
|
fixed by #6215 |
allow both dotted predicate object fields, and nested predicate objects in filters.