fix($rootScope): ng-repeat can't handle NaN values. #4605 #6192
Conversation
|
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
|
CLA signed again. |
$watchCollection checks if oldValue !== newValue which does not work for NaN Closes angular#4605
|
CLA signature verified! Thank you! Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes). |
1 similar comment
|
CLA signature verified! Thank you! Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes). |
|
Hey, so this is something we actually do a lot better in Angular.dart (and the upcoming Angular 2.0 dirty checking code), but I'm thinking we probably want to solve this in other watch algorithms than just watchCollection. But even so, this fix doesn't look too bad for $watchCollection, so I think we can do this this week. I'll schedule this for 1.3 |
|
@caitp Thanks for your feedback. May I write you an email? I have a few questions regarding Angular 2.0 and AngularDart. |
|
you can send an email, you may or may not get a helpful answer depending on the question |
|
Merged fb6062f |
$watchCollection checks if oldValue !== newValue which does not work for NaN
Closes #4605