This repository was archived by the owner on Apr 12, 2024. It is now read-only.
feat($browser): add cookie options plus ability to skip encoding #6507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
This change will add the expires, path, domain, and secure options for persisting cookies. It will also add the ability to skip encoding of cookie name and value. This change will not alter the existing API behavior. Instead it will expose the new behavior in two new methods. There is a smaller changeset for a subset of the work done in this pull request here: #6335 In addition to #6335, this pull request: - Adds a separate API that the existing cookies method utilizes - Adds an option to skip encoding for cookie name and value - Adds additional unit tests to verify new behavior This pull request would replace the need for #6335 Closes #950
|
First-time PR with AngularJS. Please let me know anything that needs changed, or any suggestions or constructive criticism. Thanks! |
|
@matsko , I'm going to end up below the fold into the backlog. 😄 What can I do to get my PR reviewed? Thanks. |
|
👍 |
petebacondarwin
force-pushed
the
master
branch
from
02dc2aa to
fd2d6c0
Compare
jeffbcross
force-pushed
the
master
branch
2 times, most recently
from
cad9560 to
f294244
Compare
jeffbcross
force-pushed
the
master
branch
4 times, most recently
from
e8dc429 to
e83fab9
Compare
petebacondarwin
force-pushed
the
master
branch
from
4dd5a20 to
998c61c
Compare
|
Cookies has been refactored, all options are now supported. Skipping encoding is not supported - this could be done in a new PR, but I am not sure if it's really needed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will add the expires, path, domain, and secure options for persisting cookies.
It will also add the ability to skip encoding of cookie name and value.
This change will not alter the existing API behavior.
Instead it will expose the new behavior in two new methods.
There is a smaller changeset for a subset of the work done in this pull request here: #6335
In addition to #6335, this pull request:
This pull request would replace the need for #6335
Closes #950