This repository was archived by the owner on Apr 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27.4k
fix(filterFilter): comparator should return true if deep object key is undefined #6623
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mixed spaces / tabs, missing semicolon, typos, already defined variables
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
No love for this? It's a simple fix. |
02dc2aa
to
fd2d6c0
Compare
cad9560
to
f294244
Compare
e8dc429
to
e83fab9
Compare
4dd5a20
to
998c61c
Compare
Based on #9757 (comment) and #9757 (comment), I believe we don't want to merge this, so closing. @Narretz: Feel free to re-open if you change your mind 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the filtering of deep object predicates was fixed in b4eed8a, an undefined key in a deep object predicate did not return true un the comparator like it does for non-nested object predicates and strings. See this plunker:
http://plnkr.co/edit/uB7Mta?p=preview
At first, p2_filter is undefined, and the filer returns no results. When you type in the input, the filter is set, and when you clear the input, it is set to empty string, returning all results.
The first commit in the pull request adds a check to the comparator to see if a key is undefined.
The second commit adds the same test for non-nested objects predicate, in line with the string filter test
The third commit fixes multiple style issues in filterSpec.js
I separated them to make the actual issue more visible
Closes #6222