This repository was archived by the owner on Apr 12, 2024. It is now read-only.
feat(limitTo): extend the filter to take a beginning index argument #6625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
Extend the limitTo filter to take an optional argument for beginning index. It provides a slice-alike functionality to manipulate the input. Closes #5355
petebacondarwin
force-pushed
the
master
branch
from
02dc2aa to
fd2d6c0
Compare
jeffbcross
force-pushed
the
master
branch
2 times, most recently
from
cad9560 to
f294244
Compare
jeffbcross
force-pushed
the
master
branch
4 times, most recently
from
e8dc429 to
e83fab9
Compare
petebacondarwin
force-pushed
the
master
branch
from
4dd5a20 to
998c61c
Compare
|
@tameraydin we are very likely to go ahead and apply the approach proposed here in 1.4. Could you please rebase your PR on top of the current master so we can review & merge it? Thnx! |
|
I rebased and also revised the code but since i have deleted my own repo, needed to fork again and create a new PR. Check out #10899 pls |
|
Thnx @tameraydin. Let's move the discussion to #10901 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request Type: feature
How to reproduce:
Component(s):
Impact: small
Complexity: small
This issue is related to:
Detailed Description:
Other Comments:
Extend the limitTo filter to take an optional argument for beginning index. It provides a slice-alike functionality to manipulate the input.
Closes #5355