Update concepts.ngdoc #6639
Update concepts.ngdoc #6639
Conversation
wrong ng-app here, it should be ng-init
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
| @@ -60,7 +60,7 @@ The loaded, transformed and rendered DOM is then called the <a name="view">"view | |||
|
|
|||
| The first kind of new markup are the so called <a name="directive">"{@link directive directives}"</a>. | |||
| They apply special behavior to attributes or elements in the HTML. In the example above we use the | |||
| {@link ng.directive:ngApp `ng-app`} attribute, which is linked to a directive that automatically | |||
| {@link ng.directive:ngApp `ng-init`} attribute, which is linked to a directive that automatically | |||
There was a problem hiding this comment.
I think ng-app is correct, here
There was a problem hiding this comment.
Yes, ng-app is correct there. @IamAnn ng-init allows you to set a scope variable to something or execute scope functions when the template first initializes.
There was a problem hiding this comment.
@petebacondarwin, would it be good to maybe show the extra markup in the source viewer in the docs? I think this is causing confusion
There was a problem hiding this comment.
but I didn't find any "ng-app" in this example. Only "ng-init" is defined on the first line in this example, am I correct?
There was a problem hiding this comment.
Yeah, the docs app is not showing it, it gets added programmatically, we need to fix that in the docs app because it's confusing
There was a problem hiding this comment.
OK, I see what's the problem here. I'm wrong. You're correct. Sorry for the trouble. But I do think it's better to show the whole markups in the source viewer as caitp suggested. Thanks for your time
|
I don't really want to dump the entire index.html into the docs as it would bloat the information. Perhaps we can have some flag on the example that says, "Don't add an ng-app to the index.html, because there is one inside the text of the example already?" @caitp - What do you think? |
|
Or even, simply, "Don't wrap this example's index.html at all"? But then we would run into problems with adding in the correct script tags... |
This doesn't seem too bad |
By setting the ng-app-included attribute to true on an example we can have the ng-app directive appear inside the example text rather than being added externally to the generated index.html. This is useful in examples that are actually show-casing the ng-app functionality. See angular/angular.js#6639
wrong ng-app here, it should be ng-init