Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Clean npm shrinkwrap #6672

Closed

Conversation

petebacondarwin
Copy link
Contributor

No description provided.

@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#6672)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@IgorMinar
Copy link
Contributor

LGTM!

petebacondarwin referenced this pull request Mar 14, 2014
This will make the following commit clearer when the update is run.
@IgorMinar
Copy link
Contributor

so we still need a way to run this automatically. this is why the PR hasn't been merged yet. I think we should merge it anyway, and figure out the automation next week (I don't think that @petebacondarwin will get to it today)

cleanModule(shrinkwrap, shrinkwrap.name);

console.log('Writing cleaned npm-shrinkwrap.json');
fs.writeFileSync('npm-shrinkwrap.json', JSON.stringify(sorted(shrinkwrap), null, 2));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh.. one more thing. we should move the file under /scripts/

IgorMinar pushed a commit to IgorMinar/angular.js that referenced this pull request Mar 14, 2014
This is to deal with npm/npm#3581

See the previous commit for more info.

Closes angular#6672
IgorMinar pushed a commit to IgorMinar/angular.js that referenced this pull request Mar 15, 2014
This is to deal with npm/npm#3581

See the previous commit for more info.

Closes angular#6672
petebacondarwin added a commit that referenced this pull request Mar 16, 2014
This is to deal with npm/npm#3581

See the previous commit for more info.

Closes #6672
@donaldpipowitch
Copy link

Did you tried https://github.com/uber/npm-shrinkwrap? Bootstrap uses this now.

@petebacondarwin petebacondarwin deleted the clean-npm-shrinkwrap branch November 24, 2016 09:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants