-
Notifications
You must be signed in to change notification settings - Fork 27.4k
Clean npm shrinkwrap #6672
Clean npm shrinkwrap #6672
Conversation
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
LGTM! |
This will make the following commit clearer when the update is run.
so we still need a way to run this automatically. this is why the PR hasn't been merged yet. I think we should merge it anyway, and figure out the automation next week (I don't think that @petebacondarwin will get to it today) |
cleanModule(shrinkwrap, shrinkwrap.name); | ||
|
||
console.log('Writing cleaned npm-shrinkwrap.json'); | ||
fs.writeFileSync('npm-shrinkwrap.json', JSON.stringify(sorted(shrinkwrap), null, 2)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh.. one more thing. we should move the file under /scripts/
This is to deal with npm/npm#3581 See the previous commit for more info. Closes angular#6672
This is to deal with npm/npm#3581 See the previous commit for more info. Closes angular#6672
This is to deal with npm/npm#3581 See the previous commit for more info. Closes #6672
Did you tried https://github.com/uber/npm-shrinkwrap? Bootstrap uses this now. |
No description provided.