This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Clean npm shrinkwrap #6672
Closed
Clean npm shrinkwrap #6672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
|
LGTM! |
petebacondarwin
referenced
this pull request
Mar 14, 2014
This will make the following commit clearer when the update is run.
|
so we still need a way to run this automatically. this is why the PR hasn't been merged yet. I think we should merge it anyway, and figure out the automation next week (I don't think that @petebacondarwin will get to it today) |
| cleanModule(shrinkwrap, shrinkwrap.name); | ||
|
|
||
| console.log('Writing cleaned npm-shrinkwrap.json'); | ||
| fs.writeFileSync('npm-shrinkwrap.json', JSON.stringify(sorted(shrinkwrap), null, 2)); |
There was a problem hiding this comment.
oh.. one more thing. we should move the file under /scripts/
IgorMinar
pushed a commit
to IgorMinar/angular.js
that referenced
this pull request
Mar 14, 2014
This is to deal with npm/npm#3581 See the previous commit for more info. Closes angular#6672
IgorMinar
pushed a commit
to IgorMinar/angular.js
that referenced
this pull request
Mar 15, 2014
This is to deal with npm/npm#3581 See the previous commit for more info. Closes angular#6672
petebacondarwin
added a commit
that referenced
this pull request
Mar 16, 2014
This is to deal with npm/npm#3581 See the previous commit for more info. Closes #6672
|
Did you tried https://github.com/uber/npm-shrinkwrap? Bootstrap uses this now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.