Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

$Document Example #6757

Closed
wants to merge 1 commit into from
Closed

Conversation

tewen
Copy link
Contributor

@tewen tewen commented Mar 20, 2014

Request Type: docs

How to reproduce:

Component(s): misc core

Impact: small

Complexity: small

This issue is related to:

Detailed Description:

An example to show how $document is essentially the same as the window.document wrapped in an angular.element expression.

Other Comments:

@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#6757)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@tewen tewen changed the title documentation example. $Document Example Mar 20, 2014
@caitp
Copy link
Contributor

caitp commented Mar 20, 2014

I dunno, I don't think this is all that useful, but on the other hand the $document page is pretty empty without it. Might as well merge it, but it's not really demonstrating any angular-ness. (also, since examples run in iframes, the titles that get rendered might confuse people)... but I guess it's ok

@caitp caitp closed this in 4d4da55 Mar 20, 2014
@tewen tewen deleted the docs-document-wrapper branch March 20, 2014 13:12
vojtajina pushed a commit that referenced this pull request Mar 21, 2014
The $document docs are pretty empty, and this fills them out a bit. The example itself may not be
particularly useful, but it could be improved or removed later. Works for me.

Closes #6757
tbosch pushed a commit to tbosch/angular.js that referenced this pull request Mar 21, 2014
The $document docs are pretty empty, and this fills them out a bit. The example itself may not be
particularly useful, but it could be improved or removed later. Works for me.

Closes angular#6757
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants