This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
refactor($compile): allow adding directive collectors and extractors #6781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
| function locateDirectives(name) { | ||
| var result = []; | ||
| forEach(environment.directiveLocators, function(locator) { | ||
| result = result.concat(locator(name) || []); |
There was a problem hiding this comment.
I feel like this potentially creates a lot of garbage for the GC to clean up... the compiler isn't really something which is called too frequently most of the time, but this potentially hurts more than it helps
There was a problem hiding this comment.
Makes sense, can be changed to
var directives = locator(name);
if (directives) result.push.apply(result, directives);Refactor `$compile` so it is able to accept directive collectors and directive extractors. Add all the current directive collectos and directive extractors that handle the current operations
petebacondarwin
force-pushed
the
master
branch
from
02dc2aa to
fd2d6c0
Compare
jeffbcross
force-pushed
the
master
branch
2 times, most recently
from
cad9560 to
f294244
Compare
jeffbcross
force-pushed
the
master
branch
4 times, most recently
from
e8dc429 to
e83fab9
Compare
petebacondarwin
force-pushed
the
master
branch
from
4dd5a20 to
998c61c
Compare
|
This is out of scope at this point in AngularJS development. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
$compileso it is able to accept directive collectors and directive extractors. Add all the current directive collectors and directive extractors that handle the current operationsThis patch is to start the conversation if the refactor into directive collectors and directive extractors should be done at 1.3 or if this should wait to 2.0